qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 22:04:44 -07:00
Code Releases Activity

net: make TestSelfConnect less fragile

Browse Source 
We believe TestSelfConnect can accidentally connect to
something else listening on or dialing from that port.

Fixes #8680.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews, rlh
https://golang.org/cl/136700043
This commit is contained in:
Russ Cox 2014-09-16 14:02:59 -04:00
parent c1c5d479bd
commit 95c899f03c
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/net/dial_test.go
View File

@ -119,6 +119,7 @@ func TestSelfConnect(t *testing.T) {
// TODO(brainman): do not know why it hangs. // TODO(brainman): do not know why it hangs.
t.Skip("skipping known-broken test on windows") t.Skip("skipping known-broken test on windows")
} }
// Test that Dial does not honor self-connects. // Test that Dial does not honor self-connects.
// See the comment in DialTCP. // See the comment in DialTCP.
@ -149,8 +150,12 @@ func TestSelfConnect(t *testing.T) {
for i := 0; i < n; i++ { for i := 0; i < n; i++ {
c, err := DialTimeout("tcp", addr, time.Millisecond) c, err := DialTimeout("tcp", addr, time.Millisecond)
if err == nil { if err == nil {
if c.LocalAddr().String() == addr {
t.Errorf("#%d: Dial %q self-connect", i, addr)
} else {
t.Logf("#%d: Dial %q succeeded - possibly racing with other listener", i, addr)
}
c.Close() c.Close()
t.Errorf("#%d: Dial %q succeeded", i, addr)
} }
} }
} }