qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 20:21:25 -07:00
Code Releases Activity

misc/cgo/testcarchive: fix build

Browse Source 
I failed to rebase (and re-test) CL 21102 before submit, which meant
that two extra tests sneaked into testcarchive that still referenced
runtime.GOOS and runtime.GOARCH.

Convert the new tests.

While we're here, make sure pending tasks are flushed before running
the host tests. If not, the "##### misc/cgo/testcarchive" banner
and "PASS" won't show up in the all.bash output.

Change-Id: I41fc4ec9515f9a193fa052f7c31fac452153c897
Reviewed-on: https://go-review.googlesource.com/21106
Run-TryBot: Elias Naur <elias.naur@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Elias Naur 2016-03-25 01:27:34 +01:00
parent 24ce64d1a9
commit 95add73abf
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
misc/cgo/testcarchive/carchive_test.go
View File

@ -227,11 +227,11 @@ func TestEarlySignalHandler(t *testing.T) {
}
func TestSignalForwarding(t *testing.T) {
switch runtime.GOOS {
switch GOOS {
case "darwin":
switch runtime.GOARCH {
switch GOARCH {
case "arm", "arm64":
t.Skipf("skipping on %s/%s; see https://golang.org/issue/13701", runtime.GOOS, runtime.GOARCH)
t.Skipf("skipping on %s/%s; see https://golang.org/issue/13701", GOOS, GOARCH)
}
case "windows":
t.Skip("skipping signal test on Windows")
@ -277,11 +277,11 @@ func TestSignalForwarding(t *testing.T) {
}
func TestSignalForwardingExternal(t *testing.T) {
switch runtime.GOOS {
switch GOOS {
case "darwin":
switch runtime.GOARCH {
switch GOARCH {
case "arm", "arm64":
t.Skipf("skipping on %s/%s; see https://golang.org/issue/13701", runtime.GOOS, runtime.GOARCH)
t.Skipf("skipping on %s/%s; see https://golang.org/issue/13701", GOOS, GOARCH)
}
case "windows":
t.Skip("skipping signal test on Windows")

1
src/cmd/dist/test.go vendored
View File

@ -696,6 +696,7 @@ func (t *tester) registerHostTest(name, dirBanner, pkg string) {
name: name,
heading: dirBanner,
fn: func(dt *distTest) error {
t.runPending(dt)
return t.runHostTest(dirBanner, pkg)
},
})