From 947cbf1911355735edc7395a97190eea60644082 Mon Sep 17 00:00:00 2001 From: Rob Findley Date: Thu, 20 Feb 2020 10:33:58 -0500 Subject: [PATCH] internal/lsp/regtest: increase test timeout to 60s In golang.org/issues/37318, it appears that the regtests are occasionally timing out on the builders. I'm not sure why they're running so slowly, but as a temporary measure lets increase the test timeout to hopefully eliminate flakes. Updates golang/go#37318 Change-Id: Id9c854ea518c9dc3618ea2b521fe6133e71af8b2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/220280 Run-TryBot: Robert Findley Reviewed-by: Rohan Challa TryBot-Result: Gobot Gobot --- internal/lsp/regtest/reg_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/lsp/regtest/reg_test.go b/internal/lsp/regtest/reg_test.go index d139e2a4b8..542b7fa458 100644 --- a/internal/lsp/regtest/reg_test.go +++ b/internal/lsp/regtest/reg_test.go @@ -44,6 +44,7 @@ func TestMain(m *testing.M) { // We don't want our forwarders to exit, but it's OK if they would have. lsprpc.ForwarderExitFunc = func(code int) {} + const testTimeout = 60 * time.Second if *runSubprocessTests { goplsPath := *goplsBinaryPath if goplsPath == "" { @@ -53,9 +54,9 @@ func TestMain(m *testing.M) { panic(fmt.Sprintf("finding test binary path: %v", err)) } } - runner = NewTestRunner(NormalModes|SeparateProcess, 30*time.Second, goplsPath) + runner = NewTestRunner(NormalModes|SeparateProcess, testTimeout, goplsPath) } else { - runner = NewTestRunner(NormalModes, 30*time.Second, "") + runner = NewTestRunner(NormalModes, testTimeout, "") } code := m.Run() runner.Close()