qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-28 21:34:30 -06:00
Code Releases Activity

cmd/compile: fix type assert in dict pass

Browse Source 
For type assertions, if src type is empty interface, we should
use normal type assertions rather than dynamic type assertions.

Fixes #53762

Change-Id: I596b2e4ad647fe5e42ad884f7273c78f8f50dac2
Reviewed-on: https://go-review.googlesource.com/c/go/+/416736
Run-TryBot: Wayne Zuo <wdvxdr@golangcn.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
This commit is contained in:
Wayne Zuo 2022-07-10 11:11:05 +08:00 committed by Heschi Kreinick
parent bf2ef26be3
commit 923740a8cc
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/compile/internal/noder/stencil.go
View File

@ -1357,7 +1357,7 @@ func (g *genInst) dictPass(info *instInfo) {
}
case ir.ODOTTYPE, ir.ODOTTYPE2:
dt := m.(*ir.TypeAssertExpr)
if !dt.Type().HasShape() && !dt.X.Type().HasShape() {
if !dt.Type().HasShape() && !(dt.X.Type().HasShape() && !dt.X.Type().IsEmptyInterface()) {
break
}
var rtype, itab ir.Node

18
test/typeparam/issue53762.go Normal file
View File

@ -0,0 +1,18 @@
// compile
// Copyright 2022 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
type Value[T any] interface {
}
func use[T any](v Value[T]) {
_, _ = v.(int)
}
func main() {
use(Value[int](1))
}