qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 15:04:44 -07:00
Code Releases Activity

internal/lsp: restore "IsIncomplete" completion flag

Browse Source 
Looks like I dropped this line accidentally after resolving a merge
conflict. I restored the original code checking the "deep" option in
addition to my intended drive-by fix of also checking the "fuzzy"
option. In either case the client should not cache completion
candidates.

Change-Id: I586daa28e3e4e4cc64665ba507245be4e91b08f2
Reviewed-on: https://go-review.googlesource.com/c/tools/+/198490
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Muir Manders 2019-10-02 14:10:34 -07:00 committed by Brad Fitzpatrick
parent f0a16743a2
commit 91543147e3
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/lsp/completion.go
View File

@ -46,7 +46,8 @@ func (s *Server) completion(ctx context.Context, params *protocol.CompletionPara
return &protocol.CompletionList{ return &protocol.CompletionList{
// When using deep completions/fuzzy matching, report results as incomplete so // When using deep completions/fuzzy matching, report results as incomplete so
// client fetches updated completions after every key stroke. // client fetches updated completions after every key stroke.
Items: toProtocolCompletionItems(candidates, rng, options), IsIncomplete: options.Completion.Deep || options.Completion.FuzzyMatching,
Items: toProtocolCompletionItems(candidates, rng, options),
}, nil }, nil
} }