qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 11:24:41 -07:00
Code Releases Activity

cmd/go/internal/work: fix error while passing custom vet tool

Browse Source 
For GOROOT packages, we were adding -unsafeptr=false to prevent unsafe.Pointer
checks. But the flag also got passed to invocations of go vet with a custom
vet tool. To prevent this from happening, we add this flag only when no
tools are passed.

Fixes #34053

Change-Id: I8bcd637fd8ec423d597fcdab2a0ceedd20786019
Reviewed-on: https://go-review.googlesource.com/c/go/+/200957
Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
This commit is contained in:
Agniva De Sarker 2019-10-13 20:33:47 +05:30 committed by Agniva De Sarker
parent c72199482f
commit 902d5aa84f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/go/internal/work/exec.go
View File

@ -1023,7 +1023,7 @@ func (b *Builder) vet(a *Action) error {
// dependency tree turn on *more* analysis, as here. // dependency tree turn on *more* analysis, as here.
// (The unsafeptr check does not write any facts for use by // (The unsafeptr check does not write any facts for use by
// later vet runs.) // later vet runs.)
if a.Package.Goroot && !VetExplicit { if a.Package.Goroot && !VetExplicit && VetTool == "" {
// Note that $GOROOT/src/buildall.bash // Note that $GOROOT/src/buildall.bash
// does the same for the misc-compile trybots // does the same for the misc-compile trybots
// and should be updated if these flags are // and should be updated if these flags are