qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 08:27:56 -07:00
Code Releases Activity

cmd/go/internal/load: treat packages with errors as potentially main packages

Browse Source 
If a package declares 'package main' but for some reason we fail to
read its name (for example, due to a permission or checksum error),
we may be tempted to drop the package from the output of
mainPackagesOnly. However, that leads to a confusing
"no packages loaded from …" error message.

Instead, we will treat packages with errors as potentially-main
packages, and print the error. At least if we print why the package is
broken, the user will understand that the weird behavior is due to the
broken package rather than, say, a typo on their part in the command
arguments.

Updates #42088
For #36460

Change-Id: I033c0d28ac7d105d9df3ba5f9327e5c0c2a29954
Reviewed-on: https://go-review.googlesource.com/c/go/+/314050
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
This commit is contained in:
Bryan C. Mills 2021-04-27 03:01:08 -04:00
parent bd2175e1b1
commit 8e0023b81b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/go/internal/load/pkg.go
View File

@ -2563,7 +2563,7 @@ func mainPackagesOnly(pkgs []*Package, patterns []string) []*Package {
mainCount := make([]int, len(patterns)) mainCount := make([]int, len(patterns))
nonMainCount := make([]int, len(patterns)) nonMainCount := make([]int, len(patterns))
for _, pkg := range pkgs { for _, pkg := range pkgs {
if pkg.Name == "main" { if pkg.Name == "main" || (pkg.Incomplete && pkg.Name == "") {
matchedPkgs = append(matchedPkgs, pkg) matchedPkgs = append(matchedPkgs, pkg)
for i := range patterns { for i := range patterns {
if matchers[i] != nil && matchers[i](pkg.ImportPath) { if matchers[i] != nil && matchers[i](pkg.ImportPath) {