From 8d880da1c42d0bc81e9e350df4f3fc4238c79873 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Fri, 9 Feb 2024 14:14:58 -0800 Subject: [PATCH] cmd/cgo/internal/test: don't skip some tests on musl They reportedly work at least as of Alpine 3.18. Fixes #39857 Change-Id: I6a249d61d33e467bf32e8c250f870fc261b90941 Reviewed-on: https://go-review.googlesource.com/c/go/+/563096 Auto-Submit: Ian Lance Taylor Commit-Queue: Ian Lance Taylor LUCI-TryBot-Result: Go LUCI Reviewed-by: Ian Lance Taylor Reviewed-by: Austin Clements --- src/cmd/cgo/internal/test/cgo_linux_test.go | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/src/cmd/cgo/internal/test/cgo_linux_test.go b/src/cmd/cgo/internal/test/cgo_linux_test.go index 3defc32ffd..f908895855 100644 --- a/src/cmd/cgo/internal/test/cgo_linux_test.go +++ b/src/cmd/cgo/internal/test/cgo_linux_test.go @@ -7,7 +7,6 @@ package cgotest import ( - "os" "runtime" "testing" ) @@ -16,9 +15,6 @@ func TestSetgid(t *testing.T) { if runtime.GOOS == "android" { t.Skip("unsupported on Android") } - if _, err := os.Stat("/etc/alpine-release"); err == nil { - t.Skip("setgid is broken with musl libc - go.dev/issue/39857") - } testSetgid(t) } @@ -26,20 +22,11 @@ func TestSetgidStress(t *testing.T) { if runtime.GOOS == "android" { t.Skip("unsupported on Android") } - if _, err := os.Stat("/etc/alpine-release"); err == nil { - t.Skip("setgid is broken with musl libc - go.dev/issue/39857") - } testSetgidStress(t) } func Test1435(t *testing.T) { test1435(t) } func Test6997(t *testing.T) { test6997(t) } - -func Test9400(t *testing.T) { - if _, err := os.Stat("/etc/alpine-release"); err == nil { - t.Skip("setgid is broken with musl libc - go.dev/issue/39857") - } - test9400(t) -} +func Test9400(t *testing.T) { test9400(t) } func TestBuildID(t *testing.T) { testBuildID(t) }