qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 21:24:55 -07:00
Code Releases Activity

os: skip TestExecutableDeleted on plan9

Browse Source 
This test deletes the running executable file, which is not safe
on Plan 9. The test was working by accident prior to commit 02ab8d1,
which must have changed the page reference ordering just enough to
cause a new demand page-in after deletion of the file.

Fixes #45941

Change-Id: Ic13d8032c21cee603e3afc3c5c4da6093fc37bf4
Reviewed-on: https://go-review.googlesource.com/c/go/+/316829
Reviewed-by: David du Colombier <0intro@gmail.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Trust: David du Colombier <0intro@gmail.com>
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
This commit is contained in:
Richard Miller 2021-05-04 17:43:26 +01:00 committed by David du Colombier
parent e15d1f4e64
commit 8c3d217d89
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/os/executable_test.go
View File

@ -90,8 +90,8 @@ func init() {
func TestExecutableDeleted(t *testing.T) {
testenv.MustHaveExec(t)
switch runtime.GOOS {
case "windows":
t.Skip("windows does not support deleting running binary")
case "windows", "plan9":
t.Skipf("%v does not support deleting running binary", runtime.GOOS)
case "openbsd", "freebsd", "aix":
t.Skipf("%v does not support reading deleted binary name", runtime.GOOS)
}