From 8bf0ed5147a95434a0204174b077fe71acc4b432 Mon Sep 17 00:00:00 2001 From: Michael Hudson-Doyle Date: Wed, 18 Feb 2015 14:58:13 +1300 Subject: [PATCH] debug/gosym: skip tests when .gosymtab section not found Skip the test when there is no .gosymtab section in the executable rather than crashing. Change-Id: Ieb3df07e307f50c33cdafab38f9b5d1ac0e55c04 Reviewed-on: https://go-review.googlesource.com/5110 Reviewed-by: Russ Cox Run-TryBot: Michael Hudson-Doyle --- src/debug/gosym/pclntab_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/debug/gosym/pclntab_test.go b/src/debug/gosym/pclntab_test.go index 1415fac276..6855a65bbe 100644 --- a/src/debug/gosym/pclntab_test.go +++ b/src/debug/gosym/pclntab_test.go @@ -84,7 +84,11 @@ func crack(file string, t *testing.T) (*elf.File, *Table) { } func parse(file string, f *elf.File, t *testing.T) (*elf.File, *Table) { - symdat, err := f.Section(".gosymtab").Data() + s := f.Section(".gosymtab") + if s == nil { + t.Skip("no .gosymtab section") + } + symdat, err := s.Data() if err != nil { f.Close() t.Fatalf("reading %s gosymtab: %v", file, err)