qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 17:00:07 -07:00
Code Releases Activity

net: use case-insensitive host string comparison in TestLookupGmailNS

Browse Source 
Some nameservers alter the case of NS records they return, e.g.
ns2.google.COm. or ns2.google.coM. Change TestLookupGmailNS to account
for this possibility by comparing host names in lower case.

Fixes #34446

Change-Id: I6ccb5b87b42401e04c9b32cecb8b7b4267b654cc
Reviewed-on: https://go-review.googlesource.com/c/go/+/196801
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Andrei Tudor Călin 2019-09-23 19:10:05 +03:00 committed by Brad Fitzpatrick
parent a14efb1be3
commit 8b6fa668ee
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/net/lookup_test.go
View File

@ -193,7 +193,9 @@ func TestLookupGmailNS(t *testing.T) {
t.Error("got no record") t.Error("got no record")
} }
for _, ns := range nss { for _, ns := range nss {
if !strings.HasSuffix(ns.Host, tt.host) { // Some nameservers alter the case of NS records. See #34446.
host := strings.ToLower(ns.Host)
if !strings.HasSuffix(host, tt.host) {
t.Errorf("got %v; want a record containing %s", ns, tt.host) t.Errorf("got %v; want a record containing %s", ns, tt.host)
} }
} }