qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 22:11:25 -07:00
Code Releases Activity

os: remove unused variable in unix implementation of File.readdir

Browse Source 
Change-Id: I0dd8a325bce6ed12d1ec1dc206ded62398925aef
Reviewed-on: https://go-review.googlesource.com/c/go/+/267758
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Brad Fitzpatrick <bradfitz@golang.org>
Trust: Emmanuel Odeke <emmanuel@orijtech.com>
This commit is contained in:
Brad Fitzpatrick 2020-11-04 11:52:43 -08:00
parent 34c09695db
commit 8ab8125fbd
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/os/dir_unix.go
View File

@ -36,9 +36,16 @@ func (f *File) readdir(n int, mode readdirMode) (names []string, dirents []DirEn
} }
d := f.dirinfo d := f.dirinfo
size := n // Change the meaning of n for the implementation below.
if size <= 0 { //
size = 100 // The n above was for the public interface of "if n <= 0,
// Readdir returns all the FileInfo from the directory in a
// single slice".
//
// But below, we use only negative to mean looping until the
// end and positive to mean bounded, with positive
// terminating at 0.
if n == 0 {
n = -1 n = -1
} }
@ -88,7 +95,9 @@ func (f *File) readdir(n int, mode readdirMode) (names []string, dirents []DirEn
if string(name) == "." || string(name) == ".." { if string(name) == "." || string(name) == ".." {
continue continue
} }
n-- if n > 0 { // see 'n == 0' comment above
n--
}
if mode == readdirName { if mode == readdirName {
names = append(names, string(name)) names = append(names, string(name))
} else if mode == readdirDirEntry { } else if mode == readdirDirEntry {