qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 00:44:39 -07:00
Code Releases Activity

regexp tests: make some benchmarks more meaningful

Browse Source 
The first two "Literal" tests were silly.
Also fix a naming typo in a couple of tests.

R=rsc
CC=golang-dev
https://golang.org/cl/4127045
This commit is contained in:
Rob Pike 2011-02-01 17:48:42 -08:00
parent 97ce34244f
commit 8a2d706487
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/pkg/regexp/all_test.go
View File

@ -316,9 +316,9 @@ func TestNumSubexp(t *testing.T) {
} }
func BenchmarkLiteral(b *testing.B) { func BenchmarkLiteral(b *testing.B) {
x := strings.Repeat("x", 50) x := strings.Repeat("x", 50) + "y"
b.StopTimer() b.StopTimer()
re := MustCompile(x) re := MustCompile("y")
b.StartTimer() b.StartTimer()
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
if !re.MatchString(x) { if !re.MatchString(x) {
@ -329,9 +329,9 @@ func BenchmarkLiteral(b *testing.B) {
} }
func BenchmarkNotLiteral(b *testing.B) { func BenchmarkNotLiteral(b *testing.B) {
x := strings.Repeat("x", 49) x := strings.Repeat("x", 50) + "y"
b.StopTimer() b.StopTimer()
re := MustCompile("^" + x) re := MustCompile(".y")
b.StartTimer() b.StartTimer()
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
if !re.MatchString(x) { if !re.MatchString(x) {

4
src/pkg/regexp/find_test.go
View File

@ -381,7 +381,7 @@ func TestFindSubmatchIndex(t *testing.T) {
} }
} }
func TestFindStringSubmatchndex(t *testing.T) { func TestFindStringSubmatchIndex(t *testing.T) {
for _, test := range findTests { for _, test := range findTests {
testFindSubmatchIndex(&test, MustCompile(test.pat).FindStringSubmatchIndex(test.text), t) testFindSubmatchIndex(&test, MustCompile(test.pat).FindStringSubmatchIndex(test.text), t)
} }
@ -452,7 +452,7 @@ func TestFindAllSubmatchIndex(t *testing.T) {
} }
} }
func TestFindAllStringSubmatchndex(t *testing.T) { func TestFindAllStringSubmatchIndex(t *testing.T) {
for _, test := range findTests { for _, test := range findTests {
testFindAllSubmatchIndex(&test, MustCompile(test.pat).FindAllStringSubmatchIndex(test.text, -1), t) testFindAllSubmatchIndex(&test, MustCompile(test.pat).FindAllStringSubmatchIndex(test.text, -1), t)
} }