qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-24 01:10:14 -06:00
Code Releases Activity

cmd/link: ignore SEH marking on PE objects

Browse Source 
Microsoft's linker looks at whether all input objects have an empty
section called @feat.00. If all of them do, then it enables SEH;
otherwise it doesn't enable that feature. So, since around the Windows
XP SP2 era, most tools that make PE objects just tack on that section,
so that it won't gimp Microsoft's linker logic. Go doesn't support SEH,
so in theory, none of this really matters to us. But actually, if the
linker tries to ingest an object with @feat.00 -- which are produced by
LLVM's resource compiler, for example -- it chokes because of the
IMAGE_SYM_ABSOLUTE section that it doesn't know how to deal with. Since
@feat.00 is just a marking anyway, skip IMAGE_SYM_ABSOLUTE sections that
are called @feat.00.

Change-Id: I1d7bfcf6001186c53e2c487c5ac251ca65efefee
Reviewed-on: https://go-review.googlesource.com/c/go/+/268239
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Trust: Alex Brainman <alex.brainman@gmail.com>
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
This commit is contained in:
Jason A. Donenfeld 2020-11-08 03:20:36 +01:00
parent 731bb54038
commit 8981092d71
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/cmd/link/internal/loadpe/ldpe.go
View File

@ -6,6 +6,7 @@
package loadpe
import (
"bytes"
"cmd/internal/bio"
"cmd/internal/objabi"
"cmd/internal/sys"
@ -359,6 +360,20 @@ func Load(l *loader.Loader, arch *sys.Arch, localSymVersion int, input *bio.Read
if pesym.SectionNumber == IMAGE_SYM_DEBUG {
continue
}
if pesym.SectionNumber == IMAGE_SYM_ABSOLUTE && bytes.Equal(pesym.Name[:], []byte("@feat.00")) {
// Microsoft's linker looks at whether all input objects have an empty
// section called @feat.00. If all of them do, then it enables SEH;
// otherwise it doesn't enable that feature. So, since around the Windows
// XP SP2 era, most tools that make PE objects just tack on that section,
// so that it won't gimp Microsoft's linker logic. Go doesn't support SEH,
// so in theory, none of this really matters to us. But actually, if the
// linker tries to ingest an object with @feat.00 -- which are produced by
// LLVM's resource compiler, for example -- it chokes because of the
// IMAGE_SYM_ABSOLUTE section that it doesn't know how to deal with. Since
// @feat.00 is just a marking anyway, skip IMAGE_SYM_ABSOLUTE sections that
// are called @feat.00.
continue
}
var sect *pe.Section
if pesym.SectionNumber > 0 {
sect = f.Sections[pesym.SectionNumber-1]