From 872a348c3885569e89a484418e42a909f0beae88 Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Thu, 16 Jan 2020 12:39:00 -0500 Subject: [PATCH] internal/lsp: don't log context.Cancelation in diagnostics Fixes golang/go#34103. Change-Id: I76e713d54422d31b587cedd0e4359c8b3bc7845e Reviewed-on: https://go-review.googlesource.com/c/tools/+/215019 Run-TryBot: Rebecca Stambler TryBot-Result: Gobot Gobot Reviewed-by: Heschi Kreinick --- internal/lsp/diagnostics.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/lsp/diagnostics.go b/internal/lsp/diagnostics.go index cdbe16d3d3..c09f08fb4c 100644 --- a/internal/lsp/diagnostics.go +++ b/internal/lsp/diagnostics.go @@ -39,6 +39,9 @@ func (s *Server) diagnose(ctx context.Context, snapshot source.Snapshot) { // Diagnose all of the packages in the workspace. go func() { wsPackages, err := snapshot.WorkspacePackages(ctx) + if ctx.Err() != nil { + return + } if err != nil { log.Error(ctx, "diagnose: no workspace packages", err, telemetry.Directory.Of(snapshot.View().Folder)) return