qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 07:38:00 -07:00
Code Releases Activity

strings: smarter growth of temporal buffer and avoid copying on return

Browse Source 
The implementation for single strings had two optimization opportunities:
1. Grow the temporary buffer by known size before appending.
2. Avoid a full copy of the result since the underlying buffer won't be mutated afterward.
Both things were leveraged by using a Builder instead of a byte slice.

Relevant benchmark results:

        name           old time/op    new time/op    delta
        SingleMatch-8    32.0µs ± 3%    26.1µs ± 3%  -18.41%  (p=0.000 n=9+10)

        name           old speed      new speed      delta
        SingleMatch-8   469MB/s ± 3%   574MB/s ± 3%  +22.56%  (p=0.000 n=9+10)

        name           old alloc/op   new alloc/op   delta
        SingleMatch-8    81.3kB ± 0%    49.0kB ± 0%  -39.67%  (p=0.000 n=10+10)

        name           old allocs/op  new allocs/op  delta
        SingleMatch-8      19.0 ± 0%      11.0 ± 0%  -42.11%  (p=0.000 n=10+10)

Change-Id: I23af56a15875206c0ff4ce29a51bec95fd48bb11
GitHub-Last-Rev: 403cfc3c27
GitHub-Pull-Request: golang/go#47766
Reviewed-on: https://go-review.googlesource.com/c/go/+/343089
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Robert Griesemer <gri@golang.org>
This commit is contained in:
Ignacio Hagopian 2021-08-17 23:52:00 +00:00 committed by Robert Griesemer
parent 29d7e5472b
commit 86ee89225a
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/strings/replace.go
View File

@ -387,7 +387,7 @@ func makeSingleStringReplacer(pattern string, value string) *singleStringReplace
} }
func (r *singleStringReplacer) Replace(s string) string { func (r *singleStringReplacer) Replace(s string) string {
var buf []byte var buf Builder
i, matched := 0, false i, matched := 0, false
for { for {
match := r.finder.next(s[i:]) match := r.finder.next(s[i:])
@ -395,15 +395,16 @@ func (r *singleStringReplacer) Replace(s string) string {
break break
} }
matched = true matched = true
buf = append(buf, s[i:i+match]...) buf.Grow(match + len(r.value))
buf = append(buf, r.value...) buf.WriteString(s[i : i+match])
buf.WriteString(r.value)
i += match + len(r.finder.pattern) i += match + len(r.finder.pattern)
} }
if !matched { if !matched {
return s return s
} }
buf = append(buf, s[i:]...) buf.WriteString(s[i:])
return string(buf) return buf.String()
} }
func (r *singleStringReplacer) WriteString(w io.Writer, s string) (n int, err error) { func (r *singleStringReplacer) WriteString(w io.Writer, s string) (n int, err error) {