From 860883f6daa98743766727e8f7e4305661fa2748 Mon Sep 17 00:00:00 2001 From: Dominik Honnef Date: Wed, 19 Oct 2016 18:14:54 +0200 Subject: [PATCH] refactor/rename: require cl-lib, use cl- namespace go-rename.el used the cl list* macro without requiring cl. This only worked for people who required it for other code. go-guru.el, before its removal from the tree, changed from cl to cl-lib, indirectly breaking go-rename.el for some users. Switch to using cl-list* and require cl-lib. Fixes golang/go#17468 Change-Id: I70f2052b9fd3d1a8671794d9a3954be218026af2 Reviewed-on: https://go-review.googlesource.com/31471 Reviewed-by: Alan Donovan --- refactor/rename/go-rename.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/refactor/rename/go-rename.el b/refactor/rename/go-rename.el index 5181ce0acf..f12d363a26 100644 --- a/refactor/rename/go-rename.el +++ b/refactor/rename/go-rename.el @@ -21,6 +21,7 @@ ;;; Code: +(require 'cl-lib) (require 'compile) (require 'go-mode) (require 'thingatpt) @@ -67,7 +68,7 @@ the `gorename' tool. With FORCE, call `gorename' with the (message "Command: %s:" args) (message "Running gorename...") ;; Use dynamic binding to modify/restore the environment - (setq success (zerop (let ((process-environment (list* goroot-env gopath-env process-environment))) + (setq success (zerop (let ((process-environment (cl-list* goroot-env gopath-env process-environment))) (apply #'call-process args)))) (insert "\n") (compilation-mode)