From 8608733e93456ec6665c6b5c90691ae8a3af7b31 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Tue, 19 Nov 2019 13:25:03 -0500 Subject: [PATCH] cmd/dist: remove extraneous '-i' from 'go test -race' command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit At one point (before GOCACHE), the '-i' flag meant, effectively, “save the intermediate results of this command to make future commands faster”. However, now that we require GOCACHE to be enabled everywhere, '-i' no longer has that meaning: the intermediate results are already saved in GOCACHE, so the -i flag merely adds extra work (copying or linking things from GOCACHE into pkg), and also adds additional failure modes resulting from that extra work (particularly when 'pkg' is read-only). Since the flag now causes more harm than good, omit it. Updates #30316 Change-Id: I295b6c0fc460dfc11ffa2a964cbb2a40f2935edc Reviewed-on: https://go-review.googlesource.com/c/go/+/207962 Run-TryBot: Bryan C. Mills Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/cmd/dist/test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 559c61a9163..0bd094e00a8 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -1327,7 +1327,7 @@ func (t *tester) runFlag(rx string) string { } func (t *tester) raceTest(dt *distTest) error { - t.addCmd(dt, "src", t.goTest(), "-race", "-i", "runtime/race", "flag", "os", "os/exec") + t.addCmd(dt, "src", t.goTest(), "-race", "runtime/race", "flag", "os", "os/exec") t.addCmd(dt, "src", t.goTest(), "-race", t.runFlag("Output"), "runtime/race") t.addCmd(dt, "src", t.goTest(), "-race", t.runFlag("TestParse|TestEcho|TestStdinCloseRace|TestClosedPipeRace|TestTypeRace|TestFdRace|TestFdReadRace|TestFileCloseRace"), "flag", "net", "os", "os/exec", "encoding/gob") // We don't want the following line, because it