qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 05:04:47 -07:00
Code Releases Activity

encoding/ascii85: make bigtest big again

Browse Source 
ascii85_test.go contains a variable called bigtest that is used as
test data for TestDecoderBuffering and TestEncoderBuffering.  The
variable is initialised to a copy of the last element of the pairs
slice.  When the variable was first added the last element of this
slice contained a sizable test case, 342 encoded characters.  However,
https://golang.org/cl/5970078 added a new element to the end of the pairs
slice without updating bigtest.  As the new element contained only 1 byte
of encoded data bigtest became very small test.  This commit fixes the
problem by resetting bigtest to its original value and making its
initialisation independent of the layout of pairs.  All the unit tests
still pass.

Change-Id: If7fb609ced9da93a2321dfd8372986b2fa772fd5
Reviewed-on: https://go-review.googlesource.com/46475
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Mark Ryan 2017-06-23 14:13:11 +01:00 committed by Brad Fitzpatrick
parent 43ae54ba2a
commit 856fd8f50e
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/encoding/ascii85/ascii85_test.go
View File

@ -16,14 +16,7 @@ type testpair struct {
decoded, encoded string
}
var pairs = []testpair{
// Encode returns 0 when len(src) is 0
{
"",
"",
},
// Wikipedia example
{
var bigtest = testpair{
"Man is distinguished, not only by his reason, but by this singular passion from " +
"other animals, which is a lust of the mind, that by a perseverance of delight in " +
"the continued and indefatigable generation of knowledge, exceeds the short " +
@ -33,7 +26,16 @@ var pairs = []testpair{
"i(DIb:@FD,*)+C]U=@3BN#EcYf8ATD3s@q?d$AftVqCh[NqF<G:8+EV:.+Cf>-FD5W8ARlolDIa\n" +
"l(DId<j@<?3r@:F%a+D58'ATD4$Bl@l3De:,-DJs`8ARoFb/0JMK@qB4^F!,R<AKZ&-DfTqBG%G\n" +
">uD.RTpAKYo'+CT/5+Cei#DII?(E,9)oF*2M7/c\n",
}
var pairs = []testpair{
// Encode returns 0 when len(src) is 0
{
"",
"",
},
// Wikipedia example
bigtest,
// Special case when shortening !!!!! to z.
{
"\000\000\000\000",
@ -41,8 +43,6 @@ var pairs = []testpair{
},
}
var bigtest = pairs[len(pairs)-1]
func testEqual(t *testing.T, msg string, args ...interface{}) bool {
t.Helper()
if args[len(args)-2] != args[len(args)-1] {