qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 21:50:03 -07:00
Code Releases Activity

misc/cgo/testshared: increase size limit in size check

Browse Source 
Recently in Fedora we switched binutils ld's separate-code on. This
led to increased size of binaries, especially on 64k aligned arches.
For example trivial test binary size grew from 80k to 211k on ppc64le
tripping the size check(RHBZ#2030308). Therefore adjusting the size limit.

Change-Id: Ic722d90c338739c0b285f40b12ba4d675e9626a2
Reviewed-on: https://go-review.googlesource.com/c/go/+/371634
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
This commit is contained in:
Jakub Čajka 2021-12-13 15:57:25 +01:00 committed by Ian Lance Taylor
parent d5fefbb498
commit 83fc0978e5
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
misc/cgo/testshared/shared_test.go
View File

@ -462,7 +462,9 @@ func TestTrivialExecutable(t *testing.T) {
run(t, "trivial executable", "../../bin/trivial") run(t, "trivial executable", "../../bin/trivial")
AssertIsLinkedTo(t, "../../bin/trivial", soname) AssertIsLinkedTo(t, "../../bin/trivial", soname)
AssertHasRPath(t, "../../bin/trivial", gorootInstallDir) AssertHasRPath(t, "../../bin/trivial", gorootInstallDir)
checkSize(t, "../../bin/trivial", 100000) // it is 19K on linux/amd64, 100K should be enough // It is 19K on linux/amd64, with separate-code in binutils ld and 64k being most common alignment
// 4*64k should be enough, but this might need revision eventually.
checkSize(t, "../../bin/trivial", 256000)
} }
// Build a trivial program in PIE mode that links against the shared runtime and check it runs. // Build a trivial program in PIE mode that links against the shared runtime and check it runs.
@ -471,7 +473,9 @@ func TestTrivialExecutablePIE(t *testing.T) {
run(t, "trivial executable", "./trivial.pie") run(t, "trivial executable", "./trivial.pie")
AssertIsLinkedTo(t, "./trivial.pie", soname) AssertIsLinkedTo(t, "./trivial.pie", soname)
AssertHasRPath(t, "./trivial.pie", gorootInstallDir) AssertHasRPath(t, "./trivial.pie", gorootInstallDir)
checkSize(t, "./trivial.pie", 100000) // it is 19K on linux/amd64, 100K should be enough // It is 19K on linux/amd64, with separate-code in binutils ld and 64k being most common alignment
// 4*64k should be enough, but this might need revision eventually.
checkSize(t, "./trivial.pie", 256000)
} }
// Check that the file size does not exceed a limit. // Check that the file size does not exceed a limit.