qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 04:34:46 -07:00
Code Releases Activity

go/types: clarify that contexts do not guarantee deduplication

Browse Source 
Documentation around the use of types.Context is unclear about whether
contexts guarantee deduplication of identical instances. Add explicit
disclaimers that this is not the case.

Fixes golang/go#51680

Change-Id: I6651587315d3cbf9e8d70a69d3e2ec5cedd00da5
Reviewed-on: https://go-review.googlesource.com/c/go/+/396536
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
This commit is contained in:
Robert Findley 2022-03-29 18:30:06 -04:00
parent 2d34af0fd6
commit 83327b4ae4
4 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/cmd/compile/internal/types2/context.go
View File

@ -12,11 +12,12 @@ import (
"sync" "sync"
) )
// An Context is an opaque type checking context. It may be used to share // A Context is an opaque type checking context. It may be used to share
// identical type instances across type-checked packages or calls to // identical type instances across type-checked packages or calls to
// Instantiate. // Instantiate. Contexts are safe for concurrent use.
// //
// It is safe for concurrent use. // The use of a shared context does not guarantee that identical instances are
// deduplicated in all cases.
type Context struct { type Context struct {
mu sync.Mutex mu sync.Mutex
typeMap map[string][]ctxtEntry // type hash -> instances entries typeMap map[string][]ctxtEntry // type hash -> instances entries

3
src/cmd/compile/internal/types2/instantiate.go
View File

@ -24,7 +24,8 @@ import (
// previous instances with the same identity. As a special case, generic // previous instances with the same identity. As a special case, generic
// *Signature origin types are only considered identical if they are pointer // *Signature origin types are only considered identical if they are pointer
// equivalent, so that instantiating distinct (but possibly identical) // equivalent, so that instantiating distinct (but possibly identical)
// signatures will yield different instances. // signatures will yield different instances. The use of a shared context does
// not guarantee that identical instances are deduplicated in all cases.
// //
// If validate is set, Instantiate verifies that the number of type arguments // If validate is set, Instantiate verifies that the number of type arguments
// and parameters match, and that the type arguments satisfy their // and parameters match, and that the type arguments satisfy their

7
src/go/types/context.go
View File

@ -12,11 +12,12 @@ import (
"sync" "sync"
) )
// An Context is an opaque type checking context. It may be used to share // A Context is an opaque type checking context. It may be used to share
// identical type instances across type-checked packages or calls to // identical type instances across type-checked packages or calls to
// Instantiate. // Instantiate. Contexts are safe for concurrent use.
// //
// It is safe for concurrent use. // The use of a shared context does not guarantee that identical instances are
// deduplicated in all cases.
type Context struct { type Context struct {
mu sync.Mutex mu sync.Mutex
typeMap map[string][]ctxtEntry // type hash -> instances entries typeMap map[string][]ctxtEntry // type hash -> instances entries

3
src/go/types/instantiate.go
View File

@ -24,7 +24,8 @@ import (
// previous instances with the same identity. As a special case, generic // previous instances with the same identity. As a special case, generic
// *Signature origin types are only considered identical if they are pointer // *Signature origin types are only considered identical if they are pointer
// equivalent, so that instantiating distinct (but possibly identical) // equivalent, so that instantiating distinct (but possibly identical)
// signatures will yield different instances. // signatures will yield different instances. The use of a shared context does
// not guarantee that identical instances are deduplicated in all cases.
// //
// If validate is set, Instantiate verifies that the number of type arguments // If validate is set, Instantiate verifies that the number of type arguments
// and parameters match, and that the type arguments satisfy their // and parameters match, and that the type arguments satisfy their