qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 18:34:40 -07:00
Code Releases Activity

internal/lsp: fix diagnostics on didChange

Browse Source 
I introduced a bug in the way that diagnostics are computed after a
didChange event in CL 208099. This will fix it. Whoever sees this first
tomorrow, feel free to LGTM and submit this CL.

Change-Id: I324c1185df456c2c5c2423fc7322b959e0117218
Reviewed-on: https://go-review.googlesource.com/c/tools/+/208262
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rohan Challa <rohan@golang.org>
This commit is contained in:
Rebecca Stambler 2019-11-21 02:10:37 -05:00
parent 947d4aa893
commit 82924fac8e
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/lsp/text_synchronization.go
View File

@ -72,8 +72,6 @@ func (s *Server) didChange(ctx context.Context, params *protocol.DidChangeTextDo
if err != nil {
return err
}
snapshot := view.Snapshot()
wasFirstChange, err := view.SetContent(ctx, uri, params.TextDocument.Version, []byte(text))
if err != nil {
return err
@ -89,7 +87,7 @@ func (s *Server) didChange(ctx context.Context, params *protocol.DidChangeTextDo
}
// Run diagnostics on the newly-changed file.
go s.diagnostics(snapshot, uri)
go s.diagnostics(view.Snapshot(), uri)
return nil
}