qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 06:14:51 -07:00
Code Releases Activity

runtime/internal/atomic: remove erroneous ABI wrappers

Browse Source 
CL 179862 introduced go:linkname directives to create ABI wrappers for
Store and Store64 on s390x, but a concurrent change (CL 180439)
replaced the Go definitions of these functions with assembly
definitions. This resulted in conflicting definitions for the ABI0
symbols, which led to a bootstrap linking failure.

Fix this by removing the now-incorrect go:linkname directives for
Store and Store64. This should fix the linux-s390x builders.

Updates #31230.

Change-Id: I8de8c03c23412fc217d428c0018cc56eb2f9996f
Reviewed-on: https://go-review.googlesource.com/c/go/+/181078
Reviewed-by: Bryan C. Mills <bcmills@google.com>
This commit is contained in:
Austin Clements 2019-06-06 17:23:19 -04:00
parent 62c309c54c
commit 82521659de
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/runtime/internal/atomic/atomic_s390x.go
View File

@ -10,8 +10,6 @@ import "unsafe"
//go:linkname Load
//go:linkname Loadp
//go:linkname Load64
//go:linkname Store
//go:linkname Store64
//go:nosplit
//go:noinline