qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 14:56:47 -07:00
Code Releases Activity

crypto/internal/mlkem768: remove crypto/rand.Read error checking

Browse Source 
After #66821 crypto/rand.Read can't return an error.

Change-Id: I185063a25ef70986448f2a300e5578de17f6e61e
Reviewed-on: https://go-review.googlesource.com/c/go/+/621979
Auto-Submit: Filippo Valsorda <filippo@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Daniel McCarney <daniel@binaryparadox.net>
This commit is contained in:
Filippo Valsorda 2024-10-21 12:08:53 +02:00 committed by Gopher Robot
parent 0568cda10a
commit 81fc3d2239
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/crypto/internal/mlkem768/mlkem768.go
View File

@ -112,19 +112,15 @@ type decryptionKey struct {
func GenerateKey() (*DecapsulationKey, error) {
// The actual logic is in a separate function to outline this allocation.
dk := &DecapsulationKey{}
return generateKey(dk)
return generateKey(dk), nil
}
func generateKey(dk *DecapsulationKey) (*DecapsulationKey, error) {
func generateKey(dk *DecapsulationKey) *DecapsulationKey {
var d [32]byte
if _, err := rand.Read(d[:]); err != nil {
return nil, errors.New("mlkem768: crypto/rand Read failed: " + err.Error())
}
rand.Read(d[:])
var z [32]byte
if _, err := rand.Read(z[:]); err != nil {
return nil, errors.New("mlkem768: crypto/rand Read failed: " + err.Error())
}
return kemKeyGen(dk, &d, &z), nil
rand.Read(z[:])
return kemKeyGen(dk, &d, &z)
}
// NewKeyFromSeed deterministically generates a decapsulation key from a 64-byte
@ -214,9 +210,7 @@ func encapsulate(cc *[CiphertextSize]byte, encapsulationKey []byte) (ciphertext,
return nil, nil, errors.New("mlkem768: invalid encapsulation key length")
}
var m [messageSize]byte
if _, err := rand.Read(m[:]); err != nil {
return nil, nil, errors.New("mlkem768: crypto/rand Read failed: " + err.Error())
}
rand.Read(m[:])
// Note that the modulus check (step 2 of the encapsulation key check from
// FIPS 203, Section 7.2) is performed by polyByteDecode in parseEK.
return kemEncaps(cc, encapsulationKey, &m)