qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-01 08:28:43 -06:00
Code Releases Activity

go/analysis: validate: report duplicates among analyzers (roots)

Browse Source 
Duplicate root analyzers caused duplicate flag registration and other problems.

Change-Id: Id0c2761529c57ed1f9a63b669e62401ebf035cc2
Reviewed-on: https://go-review.googlesource.com/c/141159
Reviewed-by: Michael Matloob <matloob@golang.org>
This commit is contained in:
Alan Donovan 2018-10-10 14:27:22 -04:00
parent be3ddffac4
commit 8149dec50d
1 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
go/analysis/validate.go
View File

@ -20,14 +20,20 @@ func Validate(analyzers []*Analyzer) error {
factTypes := make(map[reflect.Type]*Analyzer) factTypes := make(map[reflect.Type]*Analyzer)
// Traverse the Requires graph, depth first. // Traverse the Requires graph, depth first.
color := make(map[*Analyzer]uint8) // 0=white 1=grey 2=black const (
white = iota
grey
black
finished
)
color := make(map[*Analyzer]uint8)
var visit func(a *Analyzer) error var visit func(a *Analyzer) error
visit = func(a *Analyzer) error { visit = func(a *Analyzer) error {
if a == nil { if a == nil {
return fmt.Errorf("nil *Analyzer") return fmt.Errorf("nil *Analyzer")
} }
if color[a] == 0 { // white if color[a] == white {
color[a] = 1 // grey color[a] = grey
// names // names
if !validIdent(a.Name) { if !validIdent(a.Name) {
@ -64,7 +70,7 @@ func Validate(analyzers []*Analyzer) error {
return fmt.Errorf("%s.Requires[%d]: %v", a.Name, i, err) return fmt.Errorf("%s.Requires[%d]: %v", a.Name, i, err)
} }
} }
color[a] = 2 // black color[a] = black
} }
return nil return nil
@ -75,6 +81,16 @@ func Validate(analyzers []*Analyzer) error {
} }
} }
// Reject duplicates among analyzers.
// Precondition: color[a] == black.
// Postcondition: color[a] == finished.
for _, a := range analyzers {
if color[a] == finished {
return fmt.Errorf("duplicate analyzer: %s", a.Name)
}
color[a] = finished
}
return nil return nil
} }