qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-29 04:34:32 -06:00
Code Releases Activity

runtime: skip TestSegv traceback check on 386

Browse Source 
The VDSO (__kernel_vsyscall) is reachable via
asmcgocall(cgo_start_thread) on linux-386, which causes traceback to
throw.

Fixes #49182.
For #50504.

Change-Id: Idb78cb8de752203ce0ed63c2dbd2d12847338688
Reviewed-on: https://go-review.googlesource.com/c/go/+/376656
Reviewed-by: Cherry Mui <cherryyz@google.com>
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
This commit is contained in:
Michael Pratt 2022-01-07 17:11:41 -05:00
parent c74be77e63
commit 7f3eb6182b
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/runtime/crash_cgo_test.go
View File

@ -625,12 +625,20 @@ func TestSegv(t *testing.T) {
// TODO(golang.org/issue/49182): Skip, runtime
// throws while attempting to generate
// traceback.
default:
nowant := "runtime: "
if strings.Contains(got, nowant) {
t.Errorf("unexpectedly saw %q in output", nowant)
return
case "linux":
if runtime.GOARCH == "386" {
// TODO(golang.org/issue/50504): Skip,
// runtime throws while attempting to
// generate traceback from VDSO call
// via asmcgocall.
return
}
}
nowant := "runtime: "
if strings.Contains(got, nowant) {
t.Errorf("unexpectedly saw %q in output", nowant)
}
})
}
}