qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 13:50:06 -07:00
Code Releases Activity

cmd/go: skip external tests on freebsd-arm builder

Browse Source 
It is just far too slow.
I have a CL for Go 1.6 that makes many of these into internal tests.
That will improve the coverage.

It does not matter much, because basically none of the go command
tests are architecture dependent, so the other builders will catch
any problems.

Fixes freebsd-arm builder.

Change-Id: I8b2f6ac2cc1e7657019f7731c6662dc43e20bfb5
Reviewed-on: https://go-review.googlesource.com/13166
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Russ Cox 2015-08-05 10:19:12 -04:00
parent 7721ac0535
commit 7d9faaa19f
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/cmd/go/go_test.go
View File

@ -24,17 +24,16 @@ import (
"time" "time"
) )
// Whether we can run go or ./testgo. var (
var canRun = true canRun = true // whether we can run go or ./testgo
canRace = false // whether we can run the race detector
canCgo = false // whether we can use cgo
// The suffix for executables, because Windows. exeSuffix string // ".exe" on Windows
var exeSuffix string
// Whether we can run the race detector. builder = testenv.Builder()
var canRace bool skipExternalBuilder = false // skip external tests on this builder
)
// Whether we can use cgo.
var canCgo bool
func init() { func init() {
switch runtime.GOOS { switch runtime.GOOS {
@ -47,6 +46,11 @@ func init() {
} }
} }
if strings.HasPrefix(builder+"-", "freebsd-arm-") {
skipExternalBuilder = true
canRun = false
}
switch runtime.GOOS { switch runtime.GOOS {
case "windows": case "windows":
exeSuffix = ".exe" exeSuffix = ".exe"
@ -134,6 +138,10 @@ type testgoData struct {
func testgo(t *testing.T) *testgoData { func testgo(t *testing.T) *testgoData {
testenv.MustHaveGoBuild(t) testenv.MustHaveGoBuild(t)
if skipExternalBuilder {
t.Skip("skipping external tests on %s builder", builder)
}
return &testgoData{t: t} return &testgoData{t: t}
} }