qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 04:57:56 -07:00
Code Releases Activity

8g: out of register bug fix

Browse Source 
Fixes #868.

R=ken2
CC=golang-dev
https://golang.org/cl/1695049
This commit is contained in:
Russ Cox 2010-06-30 20:45:50 -07:00
parent ed39c764b8
commit 7c9ed7946c
3 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cmd/8g/ggen.c
View File

@ -672,8 +672,10 @@ cgen_shift(int op, Node *nl, Node *nr, Node *res)
a = optoas(op, nl->type); a = optoas(op, nl->type);
if(nr->op == OLITERAL) { if(nr->op == OLITERAL) {
tempname(&n2, nl->type);
cgen(nl, &n2);
regalloc(&n1, nl->type, res); regalloc(&n1, nl->type, res);
cgen(nl, &n1); gmove(&n2, &n1);
sc = mpgetfix(nr->val.u.xval); sc = mpgetfix(nr->val.u.xval);
if(sc >= nl->type->width*8) { if(sc >= nl->type->width*8) {
// large shift gets 2 shifts by width // large shift gets 2 shifts by width

11
test/fixedbugs/bug287.go Normal file
View File

@ -0,0 +1,11 @@
// errchk $G $D/$F.go
// Copyright 2010 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Used to die dividing by zero; issue 879.
package main
var mult [3][...]byte = [3][5]byte{} // ERROR "\.\.\."

18
test/fixedbugs/bug288.go Normal file
View File

@ -0,0 +1,18 @@
// $G $D/$F.go
// Copyright 2010 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Used to run out of registers on 8g. Issue 868.
package main
func main() {
var r uint32
var buf [4]byte
a := buf[0:4]
r = (((((uint32(a[3]) << 8) | uint32(a[2])) << 8) |
uint32(a[1])) << 8) | uint32(a[0])
_ = r
}