qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-06 09:21:21 -06:00
Code Releases Activity

[dev.ssa] cmd/internal/ssa: minor cleanup

Browse Source 
These were review comments for CL 6681 that didn't get sent in time.

Change-Id: If161af3655770487f3ba34535d3fb55dbfde7917
Reviewed-on: https://go-review.googlesource.com/7644
Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
Josh Bleecher Snyder 2015-03-16 16:31:13 -07:00
parent f52b234579
commit 7c2c0b4e53
4 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/cmd/internal/ssa/deadcode.go
View File

@ -86,8 +86,10 @@ func deadcode(f *Func) {
f.vid.put(v.ID)
}
}
for j := i; j < len(b.Values); j++ {
b.Values[j] = nil // aid GC
// aid GC
tail := b.Values[i:]
for j := range tail {
tail[j] = nil
}
b.Values = b.Values[:i]
}
@ -105,9 +107,10 @@ func deadcode(f *Func) {
f.bid.put(b.ID)
}
}
// zero remainder to help gc
for j := i; j < len(f.Blocks); j++ {
f.Blocks[j] = nil
// zero remainder to help GC
tail := f.Blocks[i:]
for j := range tail {
tail[j] = nil
}
f.Blocks = f.Blocks[:i]

2
src/cmd/internal/ssa/op.go
View File

@ -82,7 +82,7 @@ const (
OpStoreFP
OpStoreSP
// spill&restore ops for the register allocator. These are
// spill and restore ops for the register allocator. These are
// semantically identical to OpCopy - they do not take/return
// stores like regular memory ops do. We can get away with that because
// we know there is no aliasing to spill slots on the stack.

2
src/cmd/internal/ssa/type.go
View File

@ -34,7 +34,7 @@ var (
TypeFlags = &Flags{}
)
// typeIdentical returns whether it two arguments are the same type.
// typeIdentical reports whether its two arguments are the same type.
func typeIdentical(t, u Type) bool {
if t == TypeMem {
return u == TypeMem

9
src/cmd/internal/ssa/value.go
View File

@ -24,7 +24,7 @@ type Value struct {
// are a few other pseudo-types, see type.go.
Type Type
// Auxiliary info for this value. The type of this information depends on the opcode (& type).
// Auxiliary info for this value. The type of this information depends on the opcode and type.
Aux interface{}
// Arguments of this value
@ -67,9 +67,15 @@ func (v *Value) LongString() string {
}
func (v *Value) AddArg(w *Value) {
if v.Args == nil {
v.resetArgs() // use argstorage
}
v.Args = append(v.Args, w)
}
func (v *Value) AddArgs(a ...*Value) {
if v.Args == nil {
v.resetArgs() // use argstorage
}
v.Args = append(v.Args, a...)
}
func (v *Value) SetArg(i int, w *Value) {
@ -77,6 +83,7 @@ func (v *Value) SetArg(i int, w *Value) {
}
func (v *Value) RemoveArg(i int) {
copy(v.Args[i:], v.Args[i+1:])
v.Args[len(v.Args)-1] = nil // aid GC
v.Args = v.Args[:len(v.Args)-1]
}
func (v *Value) SetArgs1(a *Value) {