1
0
mirror of https://github.com/golang/go synced 2024-11-24 02:50:11 -07:00

cmd/go: for missing binary-only package, say where it should be

Before this CL the user effectively has to guess at the expected
location of a binary-only package. While the location is normally
obvious ($GOPATH/pkg/GOOS_GOARCH/PATH/PKG.a) it is much less so when
building with options that implicitly add an -installsufix option.

Fixes #26590

Change-Id: I753ef54d6dcf733bb456dba65a4a92e4db57a1b0
Reviewed-on: https://go-review.googlesource.com/125818
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
This commit is contained in:
Ian Lance Taylor 2018-07-25 10:03:40 -07:00
parent c0e5485bd5
commit 7b46867d6e
2 changed files with 11 additions and 1 deletions

View File

@ -411,7 +411,7 @@ func (b *Builder) build(a *Action) (err error) {
if b.IsCmdList {
return nil
}
return fmt.Errorf("missing or invalid binary-only package")
return fmt.Errorf("missing or invalid binary-only package; expected file %q", a.Package.Target)
}
if err := b.Mkdir(a.Objdir); err != nil {

View File

@ -0,0 +1,10 @@
# check that error for missing binary-only says where it should be
! go build b
stderr pkg[\\/].*a\.a
-- a/a.go --
//go:binary-only-package
package a
-- b/b.go --
package b; import "a"