qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 08:04:40 -07:00
Code Releases Activity

debug/elf: add comments explaining applyRelocations for amd64/arm64

Browse Source 
LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/155190043
This commit is contained in:
Ian Lance Taylor 2014-10-09 14:38:45 -07:00
parent f1c0899e6f
commit 7abc8c4acc
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/debug/elf/file.go
View File

@ -564,6 +564,10 @@ func (f *File) applyRelocationsAMD64(dst []byte, rels []byte) error {
continue continue
} }
// There are relocations, so this must be a normal
// object file, and we only look at section symbols,
// so we assume that the symbol value is 0.
switch t { switch t {
case R_X86_64_64: case R_X86_64_64:
if rela.Off+8 >= uint64(len(dst)) || rela.Addend < 0 { if rela.Off+8 >= uint64(len(dst)) || rela.Addend < 0 {
@ -646,6 +650,10 @@ func (f *File) applyRelocationsARM64(dst []byte, rels []byte) error {
continue continue
} }
// There are relocations, so this must be a normal
// object file, and we only look at section symbols,
// so we assume that the symbol value is 0.
switch t { switch t {
case R_AARCH64_ABS64: case R_AARCH64_ABS64:
if rela.Off+8 >= uint64(len(dst)) || rela.Addend < 0 { if rela.Off+8 >= uint64(len(dst)) || rela.Addend < 0 {