qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-07 04:26:14 -07:00
Code Releases Activity

cmd/doc: don't bother checking validity of symbols at top level

Browse Source 
No need to check as pieces further down do so anyway:

	%  go doc '&&.%$^'
	doc: symbol && is not a type in package fmt installed in "fmt"
	exit status 1
	%

Removing this check allows 'go doc sort.interface' or 'go doc
types.type' to discover sort.Interface and go/types.Type.

Easily

Fixes #34656.

Change-Id: I84352e83dd7f91a232f45a44d1a52f019a1a9a06
Reviewed-on: https://go-review.googlesource.com/c/go/+/205778
Reviewed-by: Caleb Spare <cespare@gmail.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
This commit is contained in:
Rob Pike 2019-11-07 13:57:19 +11:00
parent f5949b6067
commit 7a2baa9c48
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cmd/doc/main.go
View File

@ -358,17 +358,11 @@ func parseSymbol(str string) (symbol, method string) {
case 1: case 1:
case 2: case 2:
method = elem[1] method = elem[1]
if !token.IsIdentifier(method) {
log.Fatalf("invalid identifier %q", method)
}
default: default:
log.Printf("too many periods in symbol specification") log.Printf("too many periods in symbol specification")
usage() usage()
} }
symbol = elem[0] symbol = elem[0]
if !token.IsIdentifier(symbol) {
log.Fatalf("invalid identifier %q", symbol)
}
return return
} }