qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 06:57:58 -07:00
Code Releases Activity

encoding/gob: fix panic when decoding []byte to incompatible slice types

Browse Source 
Fixes #2662.

R=golang-dev, rogpeppe, r, r
CC=golang-dev, r, rogpeppe
https://golang.org/cl/5515050
This commit is contained in:
Alexey Borzenkov 2012-01-09 12:52:03 -08:00 committed by Rob Pike
parent 41806ec26d
commit 793768e9d5
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/pkg/encoding/gob/decode.go
View File

@ -1039,9 +1039,9 @@ func (dec *Decoder) compatibleType(fr reflect.Type, fw typeId, inProgress map[re
// Extract and compare element types. // Extract and compare element types.
var sw *sliceType var sw *sliceType
if tt, ok := builtinIdToType[fw]; ok { if tt, ok := builtinIdToType[fw]; ok {
sw = tt.(*sliceType) sw, _ = tt.(*sliceType)
} else { } else if wire != nil {
sw = dec.wireType[fw].SliceT sw = wire.SliceT
} }
elem := userType(t.Elem()).base elem := userType(t.Elem()).base
return sw != nil && dec.compatibleType(elem, sw.Elem, inProgress) return sw != nil && dec.compatibleType(elem, sw.Elem, inProgress)

8
src/pkg/encoding/gob/encoder_test.go
View File

@ -678,3 +678,11 @@ func TestUnexportedChan(t *testing.T) {
t.Fatalf("error encoding unexported channel: %s", err) t.Fatalf("error encoding unexported channel: %s", err)
} }
} }
func TestSliceIncompatibility(t *testing.T) {
var in = []byte{1, 2, 3}
var out []int
if err := encAndDec(in, &out); err == nil {
t.Error("expected compatibility error")
}
}