qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-24 17:30:18 -07:00
Code Releases Activity

gc: fix arm build

Browse Source 
Escape analysis was incorrectly assuming that
functions without bodies don't leak their
parameters.  This meant that sync/atomic's
TestAddInt64 was allocating x on its stack,
and then x was not properly aligned for use
with the atomic 64-bit instructions.  Obviously
we should figure out the alignment story on 5g
too, but this fix is correct and should restore the
build to 'ok'.

TBR=lvd
CC=golang-dev
https://golang.org/cl/4964047
This commit is contained in:
Russ Cox 2011-08-28 23:29:34 -04:00
parent a3bc7681b5
commit 77f0bdce07
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cmd/gc/esc.c
View File

@ -505,7 +505,7 @@ esccall(Node *n)
}
}
if(fn && fn->op == ONAME && fn->class == PFUNC && fn->ntype) {
if(fn && fn->op == ONAME && fn->class == PFUNC && fn->defn && fn->defn->nbody && fn->ntype) {
// Local function. Incorporate into flow graph.
// Receiver.
@ -697,6 +697,10 @@ esctag(Node *func)
Node *savefn;
NodeList *ll;
// External functions must be assumed unsafe.
if(func->nbody == nil)
return;
savefn = curfn;
curfn = func;

6
test/escape2.go
View File

@ -774,3 +774,9 @@ func foo118(unknown func(*int)) { // ERROR "unknown does not escape"
x := 1 // ERROR "moved to heap: NAME-x"
unknown(&x) // ERROR "&x escapes to heap"
}
func external(*int)
func foo119(x *int) { // ERROR "leaking param: NAME-x"
external(x)
}