qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 03:24:40 -07:00
Code Releases Activity

net/http/cgi: workaround for closure inlining issue

Browse Source 
This is a temporary workaround for issue #62277, to get the longtest
builders passing again. As mentioned on the issue, the underlying
issue was present even before CL 522318; it just now affects inlined
closures in initialization expressions too, not just explicit init
functions.

This CL can and should be reverted once that issue is fixed properly.

Change-Id: I612a501e131d1b5eea648aafeb1a3a3fe8fe8c83
Reviewed-on: https://go-review.googlesource.com/c/go/+/522935
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
This commit is contained in:
Matthew Dempsky 2023-08-24 23:14:43 -07:00 committed by Gopher Robot
parent 24b9ef1a73
commit 777e65feb6
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/net/http/cgi/host.go
View File

@ -35,7 +35,10 @@ import (
var trailingPort = regexp.MustCompile(`:([0-9]+)$`) var trailingPort = regexp.MustCompile(`:([0-9]+)$`)
var osDefaultInheritEnv = func() []string { var osDefaultInheritEnv = getOSDefaultInheritEnv()
// TODO(mdempsky): Revert CL 522935 after #62277 is fixed.
func getOSDefaultInheritEnv() []string {
switch runtime.GOOS { switch runtime.GOOS {
case "darwin", "ios": case "darwin", "ios":
return []string{"DYLD_LIBRARY_PATH"} return []string{"DYLD_LIBRARY_PATH"}
@ -51,7 +54,7 @@ var osDefaultInheritEnv = func() []string {
return []string{"SystemRoot", "COMSPEC", "PATHEXT", "WINDIR"} return []string{"SystemRoot", "COMSPEC", "PATHEXT", "WINDIR"}
} }
return nil return nil
}() }
// Handler runs an executable in a subprocess with a CGI environment. // Handler runs an executable in a subprocess with a CGI environment.
type Handler struct { type Handler struct {