qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 15:14:44 -07:00
Code Releases Activity

go/packages: replace darwin with netbsd in TestSizes

Browse Source 
The darwin/386 port has been removed per golang.org/issue/37610.
TestSizes needs an operating system that has both amd64 and 386 ports,
so darwin no longer qualifies. NetBSD has had its 386 port restored
recently in golang/go#31726, so it can be used instead.

Fixes golang/go#38319.
For golang/go#37610.

Change-Id: I37ce6d86ca3ddad43e9294e0de66f36091cba54a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/227552
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
This commit is contained in:
Dmitri Shuralyov 2020-04-08 20:22:31 -04:00 committed by Michael Matloob
parent 9ee5ef7a2c
commit 77362c5149
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
go/packages/packages_test.go
View File

@ -1584,12 +1584,12 @@ func testContainsOverlayXTest(t *testing.T, exporter packagestest.Exporter) {
// This test ensures that the effective GOARCH variable in the // This test ensures that the effective GOARCH variable in the
// application determines the Sizes function used by the type checker. // application determines the Sizes function used by the type checker.
// This behavior is a stop-gap until we make the build system's query // This behavior is a stop-gap until we make the build system's query
// too report the correct sizes function for the actual configuration. // tool report the correct sizes function for the actual configuration.
func TestSizes(t *testing.T) { packagestest.TestAll(t, testSizes) } func TestSizes(t *testing.T) { packagestest.TestAll(t, testSizes) }
func testSizes(t *testing.T, exporter packagestest.Exporter) { func testSizes(t *testing.T, exporter packagestest.Exporter) {
// Only run this test on operating systems that have both an amd64 and 386 port. // Only run this test on operating systems that have both an amd64 and 386 port.
switch runtime.GOOS { switch runtime.GOOS {
case "darwin", "linux", "windows", "freebsd", "openbsd", "android": case "linux", "windows", "freebsd", "openbsd", "netbsd", "android":
default: default:
t.Skipf("skipping test on %s", runtime.GOOS) t.Skipf("skipping test on %s", runtime.GOOS)
} }