qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 03:04:44 -07:00
Code Releases Activity

os: look up hostname from PATH in test

Browse Source 
When running TestHostname, the location of the hostname binary
is hardcoded as /bin/hostname. However, on some systems the actual
location is /usr/bin/hostname.

Change this behaviour to perform a lookup for hostname in PATH,
and skip the test when it cannot be found there.
This commit is contained in:
Silke Hofstra 2022-04-18 13:22:37 +02:00
parent cbc9e58905
commit 750f36fcf9
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/os/os_test.go
View File

@ -1699,16 +1699,21 @@ func runBinHostname(t *testing.T) string {
t.Fatal(err)
}
defer r.Close()
const path = "/bin/hostname"
path, err := osexec.LookPath("hostname")
if err != nil {
if errors.Is(err, osexec.ErrNotFound) {
t.Skip("skipping test; test requires hostname but it does not exist")
}
t.Fatal(err)
}
argv := []string{"hostname"}
if runtime.GOOS == "aix" {
argv = []string{"hostname", "-s"}
}
p, err := StartProcess(path, argv, &ProcAttr{Files: []*File{nil, w, Stderr}})
if err != nil {
if _, err := Stat(path); IsNotExist(err) {
t.Skipf("skipping test; test requires %s but it does not exist", path)
}
t.Fatal(err)
}
w.Close()