From 7497ccb9b41f1247b4c4d38f6d36aa6b337c5b0c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luka=20Krmpoti=C4=87?= Date: Mon, 21 Aug 2023 23:17:31 +0000 Subject: [PATCH] strconv: add missing function name, avoid unnecessary raw string Change-Id: Iecd68f69f5265f1a4ea41b90aa819ce68fe55908 GitHub-Last-Rev: 4d1f4a1bc2740fc19bbb4768009ccfea1c8eb5bc GitHub-Pull-Request: golang/go#62177 Reviewed-on: https://go-review.googlesource.com/c/go/+/521277 Run-TryBot: Ian Lance Taylor TryBot-Result: Gopher Robot Reviewed-by: Ian Lance Taylor Reviewed-by: Carlos Amedee Run-TryBot: Ian Lance Taylor Auto-Submit: Ian Lance Taylor --- src/strconv/atob_test.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/strconv/atob_test.go b/src/strconv/atob_test.go index 28f469f5854..40d43a9f8f9 100644 --- a/src/strconv/atob_test.go +++ b/src/strconv/atob_test.go @@ -39,19 +39,19 @@ func TestParseBool(t *testing.T) { if test.err != nil { // expect an error if e == nil { - t.Errorf("%s: expected %s but got nil", test.in, test.err) + t.Errorf("ParseBool(%s) = nil; want %s", test.in, test.err) } else { // NumError assertion must succeed; it's the only thing we return. - if test.err != e.(*NumError).Err { - t.Errorf("%s: expected %s but got %s", test.in, test.err, e) + if e.(*NumError).Err != test.err { + t.Errorf("ParseBool(%s) = %s; want %s", test.in, e, test.err) } } } else { if e != nil { - t.Errorf("%s: expected no error but got %s", test.in, e) + t.Errorf("ParseBool(%s) = %s; want nil", test.in, e) } if b != test.out { - t.Errorf("%s: expected %t but got %t", test.in, test.out, b) + t.Errorf("ParseBool(%s) = %t; want %t", test.in, b, test.out) } } } @@ -65,7 +65,7 @@ var boolString = map[bool]string{ func TestFormatBool(t *testing.T) { for b, s := range boolString { if f := FormatBool(b); f != s { - t.Errorf(`FormatBool(%v): expected %q but got %q`, b, s, f) + t.Errorf("FormatBool(%v) = %q; want %q", b, f, s) } } } @@ -85,7 +85,7 @@ func TestAppendBool(t *testing.T) { for _, test := range appendBoolTests { b := AppendBool(test.in, test.b) if !bytes.Equal(b, test.out) { - t.Errorf("AppendBool(%q, %v): expected %q but got %q", test.in, test.b, test.out, b) + t.Errorf("AppendBool(%q, %v) = %q; want %q", test.in, test.b, b, test.out) } } }