qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 13:04:45 -07:00
Code Releases Activity

runtime: fix sysctl calling convention on netbsd/386

Browse Source 
Thanks to coypoop for noticing at:

  https://github.com/golang/go/issues/22914#issuecomment-347761838

FreeBSD/386 and NetBSD/386 diverged between Go 1.4 and Go 1.5 when
Russ sent https://golang.org/cl/135830043 (git rev 25f6b02ab0)
to change the calling convention of the C compilers to match Go.
But netbsd wasn't updated.

Tested on a NetBSD/386 VM, since the builders aren't back up yet (due
to this bug)

Fixes #22914
Updates #19339
Updates #20852
Updates #16511

Change-Id: Id76ebe8f29bcc85e39b1c11090639d906cd6cf04
Reviewed-on: https://go-review.googlesource.com/80515
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Brad Fitzpatrick 2017-11-29 06:36:42 +00:00
parent 153e4096a8
commit 70ee9b4a07
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/runtime/sys_netbsd_386.s
View File

@ -375,10 +375,12 @@ TEXT runtime·sysctl(SB),NOSPLIT,$28
MOVSL // arg 6 - newlen MOVSL // arg 6 - newlen
MOVL $202, AX // sys___sysctl MOVL $202, AX // sys___sysctl
INT $0x80 INT $0x80
JCC 3(PC) JAE 4(PC)
NEGL AX NEGL AX
MOVL AX, ret+24(FP)
RET RET
MOVL $0, AX MOVL $0, AX
MOVL AX, ret+24(FP)
RET RET
GLOBL runtime·tlsoffset(SB),NOPTR,$4 GLOBL runtime·tlsoffset(SB),NOPTR,$4