qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-15 04:40:28 -07:00
Code Releases Activity

go/types, types2: better error message when selecting on a built-in

Browse Source 
Fixes #43285.

Change-Id: Iddadf76e2dc10fcf77f588c865a68125ebeda290
Reviewed-on: https://go-review.googlesource.com/c/go/+/623756
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
This commit is contained in:
Robert Griesemer 2024-10-30 15:57:42 -07:00 committed by Gopher Robot
parent d72b5bc3d7
commit 6f59c11155
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/compile/internal/types2/call.go
View File

@ -774,7 +774,7 @@ func (check *Checker) selector(x *operand, e *syntax.SelectorExpr, def *TypeName
goto Error goto Error
} }
case builtin: case builtin:
check.errorf(e.Pos(), UncalledBuiltin, "cannot select on %s", x) check.errorf(e.Pos(), UncalledBuiltin, "invalid use of %s in selector expression", x)
goto Error goto Error
case invalid: case invalid:
goto Error goto Error

2
src/go/types/call.go
View File

@ -777,7 +777,7 @@ func (check *Checker) selector(x *operand, e *ast.SelectorExpr, def *TypeName, w
} }
case builtin: case builtin:
// types2 uses the position of '.' for the error // types2 uses the position of '.' for the error
check.errorf(e.Sel, UncalledBuiltin, "cannot select on %s", x) check.errorf(e.Sel, UncalledBuiltin, "invalid use of %s in selector expression", x)
goto Error goto Error
case invalid: case invalid:
goto Error goto Error

6
src/internal/types/testdata/fixedbugs/issue51360.go vendored
View File

@ -5,9 +5,9 @@
package p package p
func _() { func _() {
len.Println /* ERROR "cannot select on len" */ len.Println /* ERROR "invalid use of len (built-in) in selector expression" */
len.Println /* ERROR "cannot select on len" */ () len.Println /* ERROR "invalid use of len (built-in) in selector expression" */ ()
_ = len.Println /* ERROR "cannot select on len" */ _ = len.Println /* ERROR "invalid use of len (built-in) in selector expression" */
_ = len /* ERROR "cannot index len" */ [0] _ = len /* ERROR "cannot index len" */ [0]
_ = *len /* ERROR "cannot indirect len" */ _ = *len /* ERROR "cannot indirect len" */
} }