qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-21 18:34:44 -07:00
Code Releases Activity

array index bug

Browse Source 
x[i]
x not addressable, i >= UINF
double evaluated i
second eval killed live registers

manifested as gob instability

R=ken
OCL=34097
CL=34099
This commit is contained in:
Russ Cox 2009-08-30 18:47:48 -07:00
parent 427a0adb39
commit 6e8524be18
2 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cmd/6g/cgen.c
View File

@ -470,9 +470,9 @@ agen(Node *n, Node *res)
agen(nl, &n3);
goto index;
}
cgen(nr, res);
tempname(&tmp, nr->type);
gmove(res, &tmp);
cgen(nr, &tmp);
nr = &tmp;
irad:
regalloc(&n3, types[tptr], res);
@ -792,7 +792,7 @@ bgen(Node *n, int true, Prog *to)
regfree(&n1);
break;
}
if(isinter(nl->type)) {
// front end shold only leave cmp to literal nil
if((a != OEQ && a != ONE) || nr->op != OLITERAL) {

25
test/fixedbugs/bug199.go Normal file
View File

@ -0,0 +1,25 @@
// $G $D/$F.go && $L $F.$A && ./$A.out
// Copyright 2009 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
type S struct {
a []int;
}
var s = &S{make([]int, 10)}
func main() {
s.a[f()] = 1 // 6g used to call f twice here
}
var n int
func f() int{
if n++; n > 1 {
panicln("f twice");
}
return 0
}