qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 17:14:44 -07:00
Code Releases Activity

cmd/dist: fix bad LC_TIME assumption in 'date' invocation

Browse Source 
With GOBUILDTIMELOGFILE set, make.bash logs the starting time using

  $ echo $(date) > file

and expects to be able to read the date back with

  time.Parse(time.UnixDate)

but in some locales the default date format is not the same as
time.UnixDate; for example on LC_TIME="en_GB.UTF-8"

  $ locale date_fmt
  %a %e %b %H:%M:%S %Z %Y

Fix this by setting LC_TIME=C before the date command invocation.

Fixes #22541

Change-Id: I59bf944bb868e2acdd816c7e35134780cdbfc6a6
Reviewed-on: https://go-review.googlesource.com/75370
Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Alberto Donizetti 2017-11-02 10:22:19 +01:00 committed by Russ Cox
parent eaf603601b
commit 6de53832ae
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/make.bash
View File

@ -70,7 +70,7 @@ if [ ! -f run.bash ]; then
fi
if [ "$GOBUILDTIMELOGFILE" != "" ]; then
echo $(date) start make.bash >"$GOBUILDTIMELOGFILE"
echo $(LC_TIME=C date) start make.bash >"$GOBUILDTIMELOGFILE"
fi
# Test for Windows.