qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-11 22:50:22 -07:00
Code Releases Activity

go/types: minor updates to comments to align with types2

Browse Source 
Change-Id: Ic4fcd67cd9222eae6b72d9e91e37f3b0293b0b8d
Reviewed-on: https://go-review.googlesource.com/c/go/+/295530
Reviewed-by: Robert Griesemer <gri@golang.org>
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
This commit is contained in:
Rob Findley 2021-02-23 11:48:15 -05:00 committed by Robert Findley
parent 42b9e3a8df
commit 6cc8aa7ece
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/go/types/conversions.go
View File

@ -142,7 +142,7 @@ func isUintptr(typ Type) bool {
} }
func isUnsafePointer(typ Type) bool { func isUnsafePointer(typ Type) bool {
// TODO(gri): Is this asBasic() instead of typ.(*Basic) correct? // TODO(gri): Is this asBasic(typ) instead of typ.(*Basic) correct?
// (The former calls under(), while the latter doesn't.) // (The former calls under(), while the latter doesn't.)
// The spec does not say so, but gc claims it is. See also // The spec does not say so, but gc claims it is. See also
// issue 6326. // issue 6326.

4
src/go/types/issues_test.go
View File

@ -385,9 +385,9 @@ func TestIssue28005(t *testing.T) {
} }
} }
if obj == nil { if obj == nil {
t.Fatal("interface not found") t.Fatal("object X not found")
} }
iface := obj.Type().Underlying().(*Interface) // I must be an interface iface := obj.Type().Underlying().(*Interface) // object X must be an interface
// Each iface method m is embedded; and m's receiver base type name // Each iface method m is embedded; and m's receiver base type name
// must match the method's name per the choice in the source file. // must match the method's name per the choice in the source file.