qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-21 19:04:44 -07:00
Code Releases Activity

bug181 - type T *struct { T } is an invalid embedded type

Browse Source 
R=ken
OCL=32886
CL=32886
This commit is contained in:
Russ Cox 2009-08-07 13:14:01 -07:00
parent 99eca57d43
commit 6c2738eb43
4 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cmd/gc/dcl.c
View File

@ -900,8 +900,10 @@ stotype(NodeList *l, int et, Type **t)
t1 = n->type;
if(t1->sym == S && isptr[t1->etype])
t1 = t1->type;
if(t1 != T && isptr[t1->etype])
if(isptr[t1->etype])
yyerror("embedded type cannot be a pointer");
else if(t1->etype == TFORW && t1->embedlineno == 0)
t1->embedlineno = lineno;
}
}

1
src/cmd/gc/go.h
View File

@ -175,6 +175,7 @@ struct Type
int32 bound; // negative is dynamic array
int32 maplineno; // first use of TFORW as map key
int32 embedlineno; // first use of TFORW as embedded type
};
#define T ((Type*)0)

8
src/cmd/gc/walk.c
View File

@ -111,7 +111,7 @@ walkdeflist(NodeList *l)
void
walkdef(Node *n)
{
int lno, maplineno;
int lno, maplineno, embedlineno;
NodeList *init;
Node *e;
Type *t;
@ -210,6 +210,7 @@ walkdef(Node *n)
// copy new type and clear fields
// that don't come along
maplineno = n->type->maplineno;
embedlineno = n->type->embedlineno;
*n->type = *t;
t = n->type;
t->sym = n->sym;
@ -226,6 +227,11 @@ walkdef(Node *n)
lineno = maplineno;
maptype(n->type, types[TBOOL]);
}
if(embedlineno) {
lineno = embedlineno;
if(isptr[t->etype])
yyerror("embedded type cannot be a pointer");
}
break;
}

11
test/fixedbugs/bug181.go Normal file
View File

@ -0,0 +1,11 @@
// errchk $G $D/$F.go
// Copyright 2009 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
type T *struct {
T; // ERROR "embed.*pointer"
}