qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 17:54:57 -07:00
Code Releases Activity

dashboard/app: properly limit commit description length

Browse Source 
Ensure that we do not split UTF-8 rune in half.
Otherwise appengine python scripts will break badly.

R=adg, r
CC=golang-dev
https://golang.org/cl/42530043
This commit is contained in:
Dmitriy Vyukov 2013-12-17 12:14:27 +04:00
parent 9e3292f107
commit 676ac131e1
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
dashboard/app/build/handler.go
View File

@ -14,6 +14,7 @@ import (
"fmt" "fmt"
"net/http" "net/http"
"strings" "strings"
"unicode/utf8"
"appengine" "appengine"
"appengine/datastore" "appengine/datastore"
@ -57,9 +58,7 @@ func commitHandler(r *http.Request) (interface{}, error) {
if err := json.NewDecoder(r.Body).Decode(com); err != nil { if err := json.NewDecoder(r.Body).Decode(com); err != nil {
return nil, fmt.Errorf("decoding Body: %v", err) return nil, fmt.Errorf("decoding Body: %v", err)
} }
if len(com.Desc) > maxDatastoreStringLen { com.Desc = limitStringLength(com.Desc, maxDatastoreStringLen)
com.Desc = com.Desc[:maxDatastoreStringLen]
}
if err := com.Valid(); err != nil { if err := com.Valid(); err != nil {
return nil, fmt.Errorf("validating Commit: %v", err) return nil, fmt.Errorf("validating Commit: %v", err)
} }
@ -459,3 +458,20 @@ func logErr(w http.ResponseWriter, r *http.Request, err error) {
func contextForRequest(r *http.Request) appengine.Context { func contextForRequest(r *http.Request) appengine.Context {
return dashboardForRequest(r).Context(appengine.NewContext(r)) return dashboardForRequest(r).Context(appengine.NewContext(r))
} }
// limitStringLength essentially does return s[:max],
// but it ensures that we dot not split UTF-8 rune in half.
// Otherwise appengine python scripts will break badly.
func limitStringLength(s string, max int) string {
if len(s) <= max {
return s
}
for {
s = s[:max]
r, size := utf8.DecodeLastRuneInString(s)
if r != utf8.RuneError || size != 1 {
return s
}
max--
}
}