qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 23:54:51 -07:00
Code Releases Activity

encoding/pem: do not try to round trip value with leading/trailing space

Browse Source 
The header is literally

	Key: Value

If the value or the key has leading or trailing spaces, those will
be lost by the round trip.

Found because testing/quick returns different values now.

Change-Id: I0f574bdbb5990689509c24309854d8f814b5efa0
Reviewed-on: https://go-review.googlesource.com/39211
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Russ Cox 2017-03-31 16:15:51 -04:00
parent 64f00fb150
commit 65c17a05e9
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/encoding/pem/pem_test.go
View File

@ -207,9 +207,10 @@ func TestLineBreaker(t *testing.T) {
func TestFuzz(t *testing.T) {
testRoundtrip := func(block Block) bool {
for key := range block.Headers {
if strings.Contains(key, ":") {
// Keys with colons cannot be encoded.
for key, val := range block.Headers {
if strings.ContainsAny(key, ":\r\n") || strings.ContainsAny(val, "\r\n") || strings.TrimSpace(key) != key || strings.TrimSpace(val) != val {
// Keys with colons or newlines cannot be encoded.
// Keys/values with surrounding spaces might lose theirs.
return true
}
}