From 65535581aaf5441b68d8d31d3f338df4042f1972 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Mon, 29 Aug 2022 16:42:21 -0400 Subject: [PATCH] cmd/go: skip gccgo cgo tests in TestScript/build_overlay cgo builds with -compiler=gccgo are broken as of CL 421879. For #54761. Updates #46731. Change-Id: I0306b0bd96669f70279fc96814cc72d934a1ad6e Reviewed-on: https://go-review.googlesource.com/c/go/+/426496 TryBot-Result: Gopher Robot Auto-Submit: Bryan Mills Reviewed-by: Matthew Dempsky Run-TryBot: Bryan Mills --- src/cmd/go/testdata/script/build_overlay.txt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/cmd/go/testdata/script/build_overlay.txt b/src/cmd/go/testdata/script/build_overlay.txt index b64bc026142..c9c6a7f9dad 100644 --- a/src/cmd/go/testdata/script/build_overlay.txt +++ b/src/cmd/go/testdata/script/build_overlay.txt @@ -83,6 +83,11 @@ go build -compiler=gccgo -overlay overlay.json -o print_trimpath_gccgo$GOEXE -tr exec ./print_trimpath_gccgo$GOEXE stdout ^\.[/\\]printpath[/\\]main.go +go build -compiler=gccgo -overlay overlay.json -o main_call_asm_gccgo$GOEXE ./call_asm +exec ./main_call_asm_gccgo$GOEXE +! stdout . + +skip 'broken as of CL 421879: see https://go.dev/issue/54761' go build -compiler=gccgo -overlay overlay.json -o main_cgo_replace_gccgo$GOEXE ./cgo_hello_replace exec ./main_cgo_replace_gccgo$GOEXE @@ -96,10 +101,6 @@ go build -compiler=gccgo -overlay overlay.json -o main_cgo_angle_gccgo$GOEXE ./ exec ./main_cgo_angle_gccgo$GOEXE stdout '^hello cgo\r?\n' -go build -compiler=gccgo -overlay overlay.json -o main_call_asm_gccgo$GOEXE ./call_asm -exec ./main_call_asm_gccgo$GOEXE -! stdout . - -- m/go.mod -- // TODO(matloob): how do overlays work with go.mod (especially if mod=readonly)