qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 07:04:43 -07:00
Code Releases Activity

runtime: exit getfull barrier if there are partial workbufs

Browse Source 
Currently, we only exit the getfull barrier if there is work on the
full list, even though the exit path will take work from either the
full or partial list. Change this to exit the barrier if there is work
on either the full or partial lists.

I believe it's currently safe to check only the full list, since
during mark termination there is no reason to put a workbuf on a
partial list. However, checking both is more robust.

Change-Id: Icf095b0945c7cad326a87ff2f1dc49b7699df373
Reviewed-on: https://go-review.googlesource.com/7840
Reviewed-by: Rick Hudson <rlh@golang.org>
This commit is contained in:
Austin Clements 2015-03-19 17:46:18 -04:00
parent 06de3f52a7
commit 653426f08f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/runtime/mgcwork.go
View File

@ -419,7 +419,7 @@ func getfull(entry int) *workbuf {
xadd(&work.nwait, +1) xadd(&work.nwait, +1)
for i := 0; ; i++ { for i := 0; ; i++ {
if work.full != 0 { if work.full != 0 || work.partial != 0 {
xadd(&work.nwait, -1) xadd(&work.nwait, -1)
b = (*workbuf)(lfstackpop(&work.full)) b = (*workbuf)(lfstackpop(&work.full))
if b == nil { if b == nil {