qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 02:24:42 -07:00
Code Releases Activity

cmd/go/internal/get: allow go get on github.com/ import paths with Unicode letters

Browse Source 
More specifically, allow Unicode letters in the directories of GitHub
repositories, which can occur and don't have a valid reason to be
disallowed by go get.

Do so by using a predefined character class, the Unicode character
property class \p{L} that describes the Unicode characters that are
letters:

	http://www.regular-expressions.info/unicode.html#category

Since it's not possible to create GitHub usernames or repositories
containing Unicode letters at this time, those parts of the import path
are still restricted to ASCII letters only.

Fix name of tested func in t.Errorf messages.

Fixes #18660.

Change-Id: Ia0ef4742bfd8317d989ef1eb1d7065e382852fe2
Reviewed-on: https://go-review.googlesource.com/41822
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Dmitri Shuralyov 2017-04-26 19:07:15 -04:00 committed by Daniel Martí
parent eb6adc27d5
commit 6511931810
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/go/internal/get/vcs.go
View File

@ -851,7 +851,7 @@ var vcsPaths = []*vcsPath{
// Github // Github
{ {
prefix: "github.com/", prefix: "github.com/",
re: `^(?P<root>github\.com/[A-Za-z0-9_.\-]+/[A-Za-z0-9_.\-]+)(/[A-Za-z0-9_.\-]+)*$`, re: `^(?P<root>github\.com/[A-Za-z0-9_.\-]+/[A-Za-z0-9_.\-]+)(/[\p{L}0-9_.\-]+)*$`,
vcs: "git", vcs: "git",
repo: "https://{root}", repo: "https://{root}",
check: noVCSSuffix, check: noVCSSuffix,

14
src/cmd/go/internal/get/vcs_test.go
View File

@ -32,6 +32,14 @@ func TestRepoRootForImportPath(t *testing.T) {
repo: "https://github.com/golang/groupcache", repo: "https://github.com/golang/groupcache",
}, },
}, },
// Unicode letters in directories (issue 18660).
{
"github.com/user/unicode/испытание",
&repoRoot{
vcs: vcsGit,
repo: "https://github.com/user/unicode",
},
},
// IBM DevOps Services tests // IBM DevOps Services tests
{ {
"hub.jazz.net/git/user1/pkgname", "hub.jazz.net/git/user1/pkgname",
@ -154,16 +162,16 @@ func TestRepoRootForImportPath(t *testing.T) {
if want == nil { if want == nil {
if err == nil { if err == nil {
t.Errorf("RepoRootForImport(%q): Error expected but not received", test.path) t.Errorf("repoRootForImportPath(%q): Error expected but not received", test.path)
} }
continue continue
} }
if err != nil { if err != nil {
t.Errorf("RepoRootForImport(%q): %v", test.path, err) t.Errorf("repoRootForImportPath(%q): %v", test.path, err)
continue continue
} }
if got.vcs.name != want.vcs.name || got.repo != want.repo { if got.vcs.name != want.vcs.name || got.repo != want.repo {
t.Errorf("RepoRootForImport(%q) = VCS(%s) Repo(%s), want VCS(%s) Repo(%s)", test.path, got.vcs, got.repo, want.vcs, want.repo) t.Errorf("repoRootForImportPath(%q) = VCS(%s) Repo(%s), want VCS(%s) Repo(%s)", test.path, got.vcs, got.repo, want.vcs, want.repo)
} }
} }
} }