qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 06:54:39 -07:00
Code Releases Activity

net/http: fix dns hijacking test

Browse Source 
The name lookups are unrooted; the test should be unrooted too.
Correctly skips the tests if the DNS config specifies a domain
suffix that has a wildcard entry causing all unrooted names to resolve.

Change-Id: I80470326a5d332f3b8d64663f765fd304c5e0811
Reviewed-on: https://go-review.googlesource.com/36253
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Russ Cox 2017-02-02 20:37:29 -05:00 committed by Brad Fitzpatrick
parent 57546d67ec
commit 64c5280844
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/net/http/transport_test.go
View File

@ -3436,7 +3436,7 @@ func skipIfDNSHijacked(t *testing.T) {
// DNS server hijacking queries. // DNS server hijacking queries.
// See issues 16732, 16716. // See issues 16732, 16716.
isDNSHijackedOnce.Do(func() { isDNSHijackedOnce.Do(func() {
addrs, _ := net.LookupHost("dns-should-not-resolve.golang.") addrs, _ := net.LookupHost("dns-should-not-resolve.golang")
isDNSHijacked = len(addrs) != 0 isDNSHijacked = len(addrs) != 0
}) })
if isDNSHijacked { if isDNSHijacked {